[PATCH] D15335: [ELF] - R_X86_64_SIZE64/R_X86_64_SIZE32 relocations implemented.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 8 09:34:17 PST 2015


ruiu added inline comments.

================
Comment at: ELF/Target.cpp:645
@@ -638,1 +644,3 @@
+    return;
+
   switch (Type) {
----------------
grimar wrote:
>   // This check could be moved at upper level, but that
>   // would require adding Target->isSizeReloc() method.
>   // SIZE32/64 relocations exist only for x64 now,
>   // so it does not need such generic handling and that is why it is here.
I don't understand why you had to do this. Is this described in the spec?


http://reviews.llvm.org/D15335





More information about the llvm-commits mailing list