[PATCH] D14612: [mips] Use multiclass patterns for f32/f64 comparisons and i32 selects.

Daniel Sanders via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 8 03:38:00 PST 2015


dsanders accepted this revision.
dsanders added a comment.
This revision is now accepted and ready to land.

LGTM with a nit.


================
Comment at: lib/Target/Mips/Mips32r6InstrInfo.td:791
@@ -805,1 +790,3 @@
 // i32 selects
+multiclass SelectInt_Pats<ValueType RC, Instruction OROp, Instruction XORiOp,
+                          Instruction SLTiOp, Instruction SLTiuOp,
----------------
'RC' normally means 'RegisterClass' in these files. Could you pick another name?


http://reviews.llvm.org/D14612





More information about the llvm-commits mailing list