[PATCH] D14309: Use updated threshold for indirect call bonus

Chandler Carruth via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 8 01:54:30 PST 2015


chandlerc added a comment.

While the source code change here makes sense, there is no test added which is not acceptable, and there was no explicit LGTM.

David, just marking a patch as accepted in Phabricator doesn't send an email. Please actually write an LGTM in the comment box and send that so others are aware.

Also, David, I would suggest waiting for others to give a final approval for changes to the inline cost mechanisms, as this isn't really an area of LLVM that you've done extensive work on (yet). Also, it isn't appropriate to LGTM this without a test that ensures we don't regress.

Easwaran, please add a test.


Repository:
  rL LLVM

http://reviews.llvm.org/D14309





More information about the llvm-commits mailing list