[PATCH] D15270: PassManagerInternal: remove unused parameters. NFC.

Francis Visoiu Mistrih via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 8 01:37:19 PST 2015


Hello Philip,

The 12/07/2015 10:43, Philip Reames wrote:
> I think this patch - and the others of similar vein you've posted - are flat
> out a bad idea.  They diminish readability for no gain.  Do you have a good
> argument for why unnamed parameters are a good idea?
The unused parameters cause warinings [-Wunused-parameter].

Would commenting the parameter names, or casting them to void in the
body of the function be a better idea?

-- 
Francis Visoiu Mistrih


More information about the llvm-commits mailing list