[PATCH] D15320: CodeGen: Redo analyzePhysRegs() and computeRegisterLiveness()

[JF Bastien via llvm-commits]

jfb added a comment.

Thanks for looking into this!

Did you re-run the repro programs in the bugs linked here <https://llvm.org/bugs/show_bug.cgi?id=25033#c7>? I want to make sure they all still pass.


================
Comment at: include/llvm/CodeGen/MachineInstrBundle.h:173
@@ +172,3 @@
+
+    /// Reg or an overlapping register is defined.
+    bool Defined;
----------------
Can you change uses of "overlapping" here and elsewhere? I think they're part of the confusion.

================
Comment at: lib/Target/X86/X86InstrInfo.cpp:4454
@@ -4453,3 @@
-    //        Once fixed, also update cmpxchg-clobber-flags.ll and
-    //        peephole-na-phys-copy-folding.ll.
-
----------------
Could you also fix peephole-na-phys-copy-folding.ll? Or does it trigger the verifier as the new FIXME says? We could pass a bigger `Neighborhood` value to `computeRegisterLiveness` if that's the case.


Repository:
  rL LLVM

http://reviews.llvm.org/D15320