[PATCH] D15306: [llvm-profdata] Add support for weighted merge of profile data (2nd try)

Nathan Slingerland via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 7 17:30:21 PST 2015


slingn added a comment.

I still think a check is a good idea for the edge case mentioned above (input contains ':' but is not specifying a weight and does not exist) so that the error message is correct. But thankfully I think since sys::fs::exists() works we can just check if the split path exists - if it doesn't fall back to default behavior. Hopefully that's a more appealing way to do this.


http://reviews.llvm.org/D15306





More information about the llvm-commits mailing list