[PATCH] D15244: [PassManager] Tuning Memory Usage of AnalysisUsage

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 7 16:13:57 PST 2015


This revision was automatically updated to reflect the committed changes.
Closed by commit rL254974: [PassManager] Tuning Memory Usage of AnalysisUsage (authored by reames).

Changed prior to commit:
  http://reviews.llvm.org/D15244?vs=41928&id=42123#toc

Repository:
  rL LLVM

http://reviews.llvm.org/D15244

Files:
  llvm/trunk/include/llvm/PassAnalysisSupport.h

Index: llvm/trunk/include/llvm/PassAnalysisSupport.h
===================================================================
--- llvm/trunk/include/llvm/PassAnalysisSupport.h
+++ llvm/trunk/include/llvm/PassAnalysisSupport.h
@@ -36,11 +36,17 @@
 ///
 class AnalysisUsage {
 public:
-  typedef SmallVector<AnalysisID, 32> VectorType;
+  typedef SmallVectorImpl<AnalysisID> VectorType;
 
 private:
   /// Sets of analyses required and preserved by a pass
-  VectorType Required, RequiredTransitive, Preserved, Used;
+  // TODO: It's not clear that SmallVector is an appropriate data structure for
+  // this usecase.  The sizes were picked to minimize wasted space, but are
+  // otherwise fairly meaningless.
+  SmallVector<AnalysisID, 8> Required;
+  SmallVector<AnalysisID, 2> RequiredTransitive;
+  SmallVector<AnalysisID, 2> Preserved;
+  SmallVector<AnalysisID, 0> Used;
   bool PreservesAll;
 
 public:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D15244.42123.patch
Type: text/x-patch
Size: 904 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151208/ce26c5b6/attachment.bin>


More information about the llvm-commits mailing list