[PATCH] D15270: PassManager: remove unused parameters. NFC.

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 7 16:11:32 PST 2015


On 7 December 2015 at 13:43, Philip Reames <listmail at philipreames.com> wrote:
> reames added a subscriber: reames.
> reames added a comment.
>
> I think this patch - and the others of similar vein you've posted - are
> flat out a bad idea.  They diminish readability for no gain.  Do you
> have a good argument for why unnamed parameters are a good idea?

Making it clear that it is not used and is there just because of the
virtual interface?

I don't have a strong preference one way or the other, but we should
probably document what we decide in the coding standard.

Cheers,
Rafael


More information about the llvm-commits mailing list