[PATCH] D15306: [llvm-profdata] Add support for weighted merge of profile data (2nd try)

David Li via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 7 15:23:27 PST 2015


davidxl added inline comments.

================
Comment at: tools/llvm-profdata/llvm-profdata.cpp:198
@@ +197,3 @@
+  if (WeightStr.find_first_of("/\\") != StringRef::npos) {
+    // Weight string contains a path delimiter - something went wrong with
+    // parsing (likely due to platform-specific behavior with mixed path
----------------
Can you add a comment indicating this works around a bug in sys::fs::exists()?


http://reviews.llvm.org/D15306





More information about the llvm-commits mailing list