[PATCH] D15306: [llvm-profdata] Add support for weighted merge of profile data (2nd try)

Nathan Slingerland via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 7 14:51:08 PST 2015


slingn added a comment.

Failed builds:

http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/7858
http://lab.llvm.org:8011/builders/clang-x86-win2008-selfhost/builds/4929

Before we try to parse the weight from each input file we check if the file exists with sys::fs::exists(). This was done to allow file names to still include the ':' delimiter character - especially important on Windows since many file paths contain ':'.

Unfortunately, this check isn't foolproof as it appears to not handle the case of mixed path delimiters as we have when running the tests:

`llvm-profdata.EXE merge D:\buildslave\clang-x64-ninja-win7\llvm\test\tools\llvm-profdata/Inputs/invalid-count-later.proftext D:\buildslave\clang-x64-ninja-win7\llvm\test\tools\llvm-profdata/Inputs/invalid-count-later.profdata -o D:\buildslave\clang-x64-ninja-win7\stage2\test\tools\llvm-profdata\Output\text-format-errors.test.tmp.out`


http://reviews.llvm.org/D15306





More information about the llvm-commits mailing list