[PATCH] D15009: [mips][microMIPS] Implement ldpc instruction
Daniel Sanders via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 7 07:16:59 PST 2015
dsanders accepted this revision.
dsanders added a comment.
This revision is now accepted and ready to land.
LGTM with a couple whitespace nits
================
Comment at: test/MC/Disassembler/Mips/micromips64r6/valid.txt:134
@@ -133,2 +133,3 @@
0x00 0x64 0x7b 0x3c # CHECK: wsbh $3, $4
+0x78 0x58 0x00 0x02 # CHECK: ldpc $2, 16
0x65 0x88 # CHECK: lw $3, 32($gp)
----------------
Inconsistent whitespace compared to other tests.
================
Comment at: test/MC/Mips/micromips64r6/valid.s:24
@@ -23,2 +23,3 @@
dalign $4, $2, $3, 5 # CHECK: dalign $4, $2, $3, 5 # encoding: [0x58,0x43,0x25,0x1c]
+ ldpc $2, 16 # CHECK: ldpc $2, 16 # encoding: [0x78,0x58,0x00,0x02]
lw $3, 32($gp) # CHECK: lw $3, 32($gp) # encoding: [0x65,0x88]
----------------
Alignment of the '# encoding'.
http://reviews.llvm.org/D15009
More information about the llvm-commits
mailing list