[PATCH] D15236: [ARM] Generate ABI_optimization_goals build attribute, as described in the ARM ARM.

[Renato Golin via llvm-commits]

rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.

LGTM. Thanks!


================
Comment at: lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp:257
@@ -256,3 +256,3 @@
     unsigned IntValue;
-    StringRef StringValue;
+    std::string StringValue;
 
----------------
tyomitch wrote:
> rengolin wrote:
> > This looks like too big a hammer... Where is the pattern that breaks?
> I'd argue that this was a bug that went unnoticed for a very long while...  (see below)
Good point. If they need to keep the value until after the call, then they need to be copied every time.


http://reviews.llvm.org/D15236