[PATCH] D15191: [ELF] Support PHDRS command
Denis Protivensky via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 7 01:27:18 PST 2015
denis-protivensky added inline comments.
================
Comment at: ELF/Writer.cpp:865
@@ +864,3 @@
+ std::vector<StringRef> PhdrNames;
+ for (OutputSectionBase<ELFT> *Sec : OutputSections) {
+ const std::vector<StringRef> &NewPhdrNames =
----------------
ruiu wrote:
> This for loop is probably too long. Isn't there any way to split?
Done, thanks. This also allowed me to add one more check with test case when no sections assigned to PHDRS.
http://reviews.llvm.org/D15191
More information about the llvm-commits
mailing list