[PATCH] D13762: [Polly] Ensure unique implicit reads/writes at beginning/end of ScopStmts

[Tobias Grosser via llvm-commits]

grosser added a comment.

Hi Michael,

two brief comments:


================
Comment at: lib/Analysis/ScopInfo.cpp:891
@@ -889,2 +890,3 @@
+    else if (Access->isScalar())
       Ty = ScopArrayInfo::KIND_SCALAR;
     else
----------------
Meinersbur wrote:
> grosser wrote:
> > This seems good, but unrelated. Can you commit this ahead of time.
> is Scalar is introduced in D13676. It maybe should belong to that patch.
As the two changes belong together, but are independent of anything else, I think you can just commit them directly (as obvious).

================
Comment at: lib/Analysis/ScopInfo.cpp:3395
@@ -3343,9 +3394,3 @@
   // Check if there are accesses contained.
-  bool ContainsAccesses = false;
-  if (!RN->isSubRegion())
-    ContainsAccesses = getAccessFunctions(BB);
-  else
-    for (BasicBlock *RBB : RN->getNodeAs<Region>()->blocks())
-      ContainsAccesses |= (getAccessFunctions(RBB) != nullptr);
-  if (!ContainsAccesses)
+  if (Stmt->isEmpty())
     return true;
----------------
Meinersbur wrote:
> grosser wrote:
> > This looks good, but it seems independently useful? Could you commit this by itself?
> getStmtForRegionNode was introduced in this patch
As getStmtForRegionNode does not pull in other dependences, you can just commit the changes above and getStmtForRegionNode ahead of time.


http://reviews.llvm.org/D13762