[PATCH] D14697: [Verifier] Fix !dbg validation if Scope is the Subprogram

[Keno Fischer via llvm-commits]

Ok, thanks. I'll go ahead and commit as is then.

On Sat, Dec 5, 2015 at 8:37 PM, Duncan P. N. Exon Smith <
dexonsmith at apple.com> wrote:

>
> > On 2015-Dec-05, at 13:38, Keno Fischer <kfischer at college.harvard.edu>
> wrote:
> >
> > loladiro added a comment.
> >
> > I would appreciate some guidance on how to go forward here. Walking and
> caching the intermediate chains doesn't make this significantly simpler, so
> the primary questions is whether the caching is worth it at all.
> Unfortunately, I don't have any large enough test cases with meaningfully
> nested inlining structures to be able to make such measurements here.
> >
> >
> > http://reviews.llvm.org/D14697
>
> It looks like you're not really changing the algorithm, just fixing a
> bug where the SP could be missed.  In that case, this patch LGTM (as
> it is); it is clearly making things better.
>
> Changing the algorithm in the future to do some extra caching (or no
> caching) might be a good idea, but that seems independent.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151206/9110e687/attachment.html>