[PATCH] D14706: [lit] Implement support of per test timeout in lit.

Jonathan Roelofs via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 6 08:09:19 PST 2015


jroelofs added a comment.

When I tried to implement this a year ago, it turned out not to be possible on python 2.7 (without the external library).  The features needed to make it work weren't added until 3.2, I believe.

I think having psutil as a soft dependency is fine.


================
Comment at: utils/lit/lit/TestRunner.py:584
@@ -473,3 +583,3 @@
     # convert to list before returning.
     return list(map(processLine, script))
 
----------------
delcypher wrote:
> jroelofs wrote:
> > Oh cool, I've never noticed Phabricator highlighting rebase changes before.
> I don't see anything different. Maybe that's because you added a comment?
> 
> That change (r253556) was a bug I found in lit while working on this patch. I committed that fix directly to trunk
> because I thought it was trivial enough to not need reviewing.
I was looking at the diff of Diff 5 vs Diff 6. And yeah, I'd consider that trivial too.


http://reviews.llvm.org/D14706





More information about the llvm-commits mailing list