[PATCH] D15193: [ELF/AArch64] Allow only valid dynamic relocations in the output.
Rui Ueyama via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 4 18:22:12 PST 2015
ruiu added a comment.
LGTM
================
Comment at: lld/trunk/ELF/Target.cpp:886
@@ +885,3 @@
+ error("Relocation " + S + " cannot be used when making a shared object; "
+ "recompile with -fPIC.");
+}
----------------
ikudrin wrote:
> ruiu wrote:
> > Please format this line using clang-format.
> It is clang-formatted. Please note, there is no '+' sign between strings. Would you like me to add it and reformat then?
If it is formatted by clang-format, I'm fine with that.
http://reviews.llvm.org/D15193
More information about the llvm-commits
mailing list