[llvm] r254737 - [CXX TLS calling convention] Add CXX TLS calling convention.

[Joerg Sonnenberger via llvm-commits]

On Fri, Dec 04, 2015 at 04:35:14PM -0500, James Y Knight wrote:
> On Dec 4, 2015, at 2:32 PM, Joerg Sonnenberger via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> > On Fri, Dec 04, 2015 at 05:40:13PM -0000, Manman Ren via llvm-commits wrote:
> >> Author: mren
> >> Date: Fri Dec  4 11:40:13 2015
> >> New Revision: 254737
> >> 
> >> URL: http://llvm.org/viewvc/llvm-project?rev=254737&view=rev
> >> Log:
> >> [CXX TLS calling convention] Add CXX TLS calling convention.
> > 
> > What the motivation for this? Is there any ABI documentation for it?
> 
> 
> This seems very much like an x86_64-Darwin specific calling convention,
> which is masquerading as a generic calling convention. Why not call it
> what it actually is, instead of pretending it's something generically useful?

I'm not sure if it is Darwin-specific, but one of the things I wonder
about is the "CXX" part in the name. If it is for use by dynamic TLS
initialisers, there is nothing C++ specific about it.

I would be nice if such patches could be posted for review in advance
and with a bit more than a cryptic rdar link that the non-Apple
developers have no access to.

Joerg