[PATCH] D15024: [ThinLTO] Support for specifying function index from pass manager

[Teresa Johnson via llvm-commits]

On Fri, Dec 4, 2015 at 12:35 PM, Mehdi AMINI <mehdi.amini at apple.com> wrote:
> joker.eph requested changes to this revision.
> joker.eph added a comment.
> This revision now requires changes to proceed.
>
> The function index is owned by the PassManagerBuilder in this patch, which is not good: there is not guarantee it will outlive the PassManager. The PassManagerBuild should take a pointer and not own the FunctionIndex I think.

Ack, yes. Left ownership on the EmitAssemblyHelper which creates and
then runs the passes. New patches coming.

>
>
> http://reviews.llvm.org/D15024
>
>
>



-- 
Teresa Johnson | Software Engineer | tejohnson at google.com | 408-460-2413