[PATCH] D15191: [ELF] Support PHDRS command

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/Writer.cpp:861
@@ -838,1 +860,3 @@
 
+template <class ELFT>
+void Writer<ELFT>::layoutCustomPhdrs(uintX_t &VA, uintX_t &FileOff) {
----------------
This function needs a function comment to describe what it is intended to do.

================
Comment at: ELF/Writer.cpp:865
@@ +864,3 @@
+  std::vector<StringRef> PhdrNames;
+  for (OutputSectionBase<ELFT> *Sec : OutputSections) {
+    const std::vector<StringRef> &NewPhdrNames =
----------------
This for loop is probably too long. Isn't there any way to split?


http://reviews.llvm.org/D15191