[PATCH] D15059: [IndVars] Have getInsertPointForUses preserve LCSSA
Michael Zolotukhin via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 4 11:58:17 PST 2015
mzolotukhin accepted this revision.
mzolotukhin added a comment.
This revision is now accepted and ready to land.
Hi Sanjoy,
Thanks for fixing this, and sorry for the delayed response - I was on vacation. The patch looks good to me!
One question: are you certain that ind-vars was only breaking LCSSA for inner loops, and it's been always preserving LCSSA for other loops?
Michael
================
Comment at: lib/Analysis/LoopInfo.cpp:203
@@ -202,1 +202,3 @@
+bool Loop::isRecursivelyLCSSAForm(DominatorTree &DT) const {
+ if (!isLCSSAForm(DT))
----------------
Could you add a comment for this function please?
http://reviews.llvm.org/D15059
More information about the llvm-commits
mailing list