[llvm] r254201 - [ARM] Generate ABI_optimization_goals build attribute, as described in the ARM ARM.

[Artyom Skrobov via llvm-commits]

Renato, thank you for your help with investigating this issue!

It's now traced to an annoying case of use-after-free :-|

OK to recommit with the following simple fix?

diff --git a/lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp b/lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp
index f316ad1..6084f22 100644
--- a/lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp
+++ b/lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp
@@ -254,7 +254,7 @@ private:
     } Type;
     unsigned Tag;
     unsigned IntValue;
-    StringRef StringValue;
+    std::string StringValue;
 
     static bool LessTag(const AttributeItem &LHS, const AttributeItem &RHS) {
       // The conformance tag must be emitted first when serialised


-----Original Message-----
From: Renato Golin [mailto:renato.golin at linaro.org] 
Sent: 01 December 2015 10:36
To: Artyom Skrobov
Cc: LLVM Commits
Subject: Re: [llvm] r254201 - [ARM] Generate ABI_optimization_goals build attribute, as described in the ARM ARM.

On 1 December 2015 at 10:32, Artyom Skrobov <artyom.skrobov at arm.com> wrote:
> Thanks for that Renato!
>
> However, I didn't see any buildbot failures after my follow-up fix (r254202)

The bots were still broken after the "fix".


> OK to re-commit the two?

Once you have tested on the three cases it failed on ARM: native
self-hosting, test-suite and sanitizers locally and made sure it all
pass, yes.

cheers,
--renato