[PATCH] D15215: Emit function alias to data as a function symbol

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 3 16:26:26 PST 2015


pcc added inline comments.

================
Comment at: lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1194
@@ +1193,3 @@
+        !isa<Function>(Alias.getAliasee()))
+      OutStreamer->EmitSymbolAttribute(Name, MCSA_ELF_TypeFunction);
+
----------------
It shouldn't do any harm to emit that directive redundantly, so I'd prefer to remove it, as it makes the code easier to reason about.


Repository:
  rL LLVM

http://reviews.llvm.org/D15215





More information about the llvm-commits mailing list