[PATCH] D15211: [ProfileData] Add unit test infrastructure for sample profile reader/writer

David Li via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 3 15:50:21 PST 2015


davidxl added inline comments.

================
Comment at: include/llvm/ProfileData/SampleProfReader.h:270
@@ -269,1 +269,3 @@
 
+  // \brief Create a sample profile reader from the supplied memory buffer.
+  static ErrorOr<std::unique_ptr<SampleProfileReader>>
----------------
///

================
Comment at: include/llvm/ProfileData/SampleProfWriter.h:32
@@ -31,3 +31,3 @@
 public:
   SampleProfileWriter(StringRef Filename, std::error_code &EC,
                       sys::fs::OpenFlags Flags)
----------------
Is this constructor redundant now?


http://reviews.llvm.org/D15211





More information about the llvm-commits mailing list