[PATCH] D15210: [WebAssembly] Fix dominance check for PHIs in the StoreResult pass

Dan Gohman via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 3 14:33:02 PST 2015


sunfish created this revision.
sunfish added a reviewer: dschuff.
sunfish added a subscriber: llvm-commits.
sunfish set the repository for this revision to rL LLVM.
Herald added subscribers: dschuff, jfb.

When a block has no terminator instructions, getFirstTerminator() returns end(), which can't be used in dominance checks. Check dominance for phi operands separately.

Also, remove some bits from WebAssemblyRegStackify.cpp that were causing trouble on the same testcase; they were left behind from an earlier experiment.

Repository:
  rL LLVM

http://reviews.llvm.org/D15210

Files:
  lib/Target/WebAssembly/WebAssemblyRegStackify.cpp
  lib/Target/WebAssembly/WebAssemblyStoreResults.cpp
  test/CodeGen/WebAssembly/store-results.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D15210.41805.patch
Type: text/x-patch
Size: 4401 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151203/f4361d8d/attachment.bin>


More information about the llvm-commits mailing list