[llvm] r254654 - [llvm-objdump] Use report_fatal_error() if we can't find a target.
Davide Italiano via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 3 14:13:40 PST 2015
Author: davide
Date: Thu Dec 3 16:13:40 2015
New Revision: 254654
URL: http://llvm.org/viewvc/llvm-project?rev=254654&view=rev
Log:
[llvm-objdump] Use report_fatal_error() if we can't find a target.
Modified:
llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp
Modified: llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp?rev=254654&r1=254653&r2=254654&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp (original)
+++ llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp Thu Dec 3 16:13:40 2015
@@ -282,10 +282,8 @@ static const Target *getTarget(const Obj
std::string Error;
const Target *TheTarget = TargetRegistry::lookupTarget(ArchName, TheTriple,
Error);
- if (!TheTarget) {
- errs() << ToolName << ": " << Error;
- return nullptr;
- }
+ if (!TheTarget)
+ report_fatal_error("can't find target: " + Error);
// Update the triple name and return the found target.
TripleName = TheTriple.getTriple();
@@ -805,10 +803,6 @@ static bool getHidden(RelocationRef RelR
static void DisassembleObject(const ObjectFile *Obj, bool InlineRelocs) {
const Target *TheTarget = getTarget(Obj);
- // getTarget() will have already issued a diagnostic if necessary, so
- // just bail here if it failed.
- if (!TheTarget)
- return;
// Package up features to be passed to target/subtarget
std::string FeaturesStr;
More information about the llvm-commits
mailing list