[PATCH] D14348: Add Printable class to simplify the construction of Print helpers.

Matthias Braun via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 3 13:52:16 PST 2015


MatzeB updated this revision to Diff 41799.
MatzeB added a comment.

Updated version which uses std::function<void(raw_ostream&)> similar to C++ IO manipulators directly instead of adding a pointless shim class around the std::function.
I still found the code slightly easier to read when giving the concept an explicit name with "typedef std::function<void(raw_ostream&)> Printable", though I have no strong opinion here and can change that if you prefer the plain form without typedef.


Repository:
  rL LLVM

http://reviews.llvm.org/D14348

Files:
  include/llvm/Support/raw_ostream.h
  include/llvm/Target/TargetRegisterInfo.h
  lib/CodeGen/TargetRegisterInfo.cpp
  lib/Support/raw_ostream.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D14348.41799.patch
Type: text/x-patch
Size: 8586 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151203/08218545/attachment.bin>


More information about the llvm-commits mailing list