[PATCH] D12094: Avoid the propagation of debug locations in SelectionDAG via CSE

[Wolfgang Pieb via llvm-commits]

wolfgangp added inline comments.

================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:853
@@ -852,3 +852,3 @@
   AddNodeIDCustom(ID, N);
-  SDNode *Node = FindNodeOrInsertPos(ID, N->getDebugLoc(), InsertPos);
+  SDNode *Node = FindNodeOrInsertPos(ID, SDLoc(), InsertPos);
   return Node;
----------------
I didn't author the original code, but I see no reason to not update the DebugLoc. This routine is called from DAGCombine in an attempt to reuse a binary commutative node. Thanks for pointing this out.


http://reviews.llvm.org/D12094