[PATCH] D15139: [IR] Reformulate LLVM's EH funclet IR

[Andy Kaylor via llvm-commits]

andrew.w.kaylor added inline comments.

================
Comment at: docs/ExceptionHandling.rst:761
@@ +760,3 @@
+  catch.dispatch2:                                  ; preds = %catch
+    %2 = catchswitch within %1, unwind to caller [label %catch3]
+
----------------
This is out of sync with your latest update, right?

================
Comment at: docs/LangRef.rst:5368
@@ +5367,3 @@
+    dispatch1:
+      %cs1 = catchswitch within none, unwind to caller [label %handler0, label %handler1]
+    dispatch2:
----------------
The syntax is stale here.

================
Comment at: docs/LangRef.rst:5430
@@ +5429,3 @@
+    dispatch:
+      %cs = catchswitch within none, unwind to caller [label %handler0]
+      ;; A catch block which can catch an integer.
----------------
Stale syntax

================
Comment at: include/llvm/IR/Instructions.h:4164
@@ +4163,3 @@
+  /// \brief Methods for support type inquiry through isa, cast, and dyn_cast:
+  static inline bool classof(const Instruction *I) {
+    return I->getOpcode() == Instruction::CatchPad;
----------------
I suppose that makes some sense.  It would be nice to have a comment somewhere in the class definition explaining that.

================
Comment at: lib/Analysis/CFG.cpp:21
@@ -19,1 +20,3 @@
+#include "llvm/IR/Constants.h"
+#include "llvm/Support/Debug.h"
 
----------------
Can these includes go away now?


http://reviews.llvm.org/D15139