[PATCH] D14687: Macro support in LLVM IR

[Duncan P. N. Exon Smith via llvm-commits]

> On 2015-Dec-03, at 04:24, Amjad Aboud <amjad.aboud at intel.com> wrote:
> 
> aaboud added a comment.
> 
> In http://reviews.llvm.org/D14687#300604, @samsonov wrote:
> 
>> In http://reviews.llvm.org/D14687#300235, @aaboud wrote:
>> 
>>> Hi Alexey,
>>> You asked me to do some changes, and I explained why I cannot do them.
>>> Can you read my answers and let me know if you approve committing the patch like this or you still think I should do the changes?
>> 
>> 
>> Me? What changes do you refer to?
> 
> 
> Sorry, I got confused :)
> Duncan was the one who asked me to do the changes, he already answered my ping to you.
> 
>> Any requirements for bitcode record order are unrelated to textual IR syntax and C++ API.  Do what you have to do to read old bitcode, but that shouldn't block making the C++ API and textual IR natural.
> 
>> 
> 
>> I don't really care where the macros show up in the bitcode records, since there are relatively few humans that read those.
> 
> 
> I will then do the right order in LLVM textual IR, i.e. "macros" before "dwoId",

Please also fix the C++ API (the factory functions).

> but will keep the other order in the bitcode to be able to be backward compatible.
> Will upload a new version soon.
> 
> 
> Repository:
>  rL LLVM
> 
> http://reviews.llvm.org/D14687
> 
> 
>