[PATCH] D13633: Type legalizer for masked gather/scatter intrinsics

[Mitch Bodart via llvm-commits]

mbodart added inline comments.

================
Comment at: ../lib/CodeGen/SelectionDAG/LegalizeTypes.cpp:1115
@@ +1114,3 @@
+  if (getTypeAction(Bool.getValueType()) == TargetLowering::TypePromoteInteger)
+    Bool = GetPromotedInteger(Bool);
+
----------------
mbodart wrote:
> It seems important here that the value returned by GetPromotedInteger matches the promotion operation (e.g.. sign extension) performed by PromoteTargetBoolean.
> How is that guaranteed?
Using SExt unconditionally seems incorrect.
Don't we want to make the choice of ZExt vs SExt dependent on getBooleanContents?
Perhaps we should add getExtendForVectorContent, similar to the existing scalar getExtendForContent.


Repository:
  rL LLVM

http://reviews.llvm.org/D13633