[PATCH] D15167: [WebAssembly] Add a test for wasm-store-results pass

Dan Gohman via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 2 16:33:19 PST 2015


sunfish accepted this revision.
sunfish added a comment.
This revision is now accepted and ready to land.

Please add a little one-line comment at the top of the file describing what's being tested.

Otherwise, lgtm. Thanks for catching this.


================
Comment at: test/CodeGen/WebAssembly/store-results.ll:13
@@ +12,3 @@
+entry:
+  store volatile i32 0, i32* %p
+  ret i32 0
----------------
The `volatile` here isn't necessary.


http://reviews.llvm.org/D15167





More information about the llvm-commits mailing list