[PATCH] D14547: [llvm-profdata] Add support for weighted merge of profile data

[Sean Silva via llvm-commits]

silvas added inline comments.

================
Comment at: docs/CommandGuide/llvm-profdata.rst:31
@@ -30,3 +30,3 @@
 
-:program:`llvm-profdata merge` [*options*] [*filenames...*]
+:program:`llvm-profdata merge` [*options*] [*filenames[:weights]...*]
 
----------------
this is confusing. I interpret `filenames[:weights]...` as that there are multiple weights for a given filename. It seems like `filename[:weight] ...` is a better way to describe it. The repetition comes from the `...` not from the plurality of the name (I would say that what was there previously was incorrect).

================
Comment at: docs/CommandGuide/llvm-profdata.rst:40
@@ -39,1 +39,3 @@
 
+An optional weight may be specified for each file by appending ``:<weight>``
+to the filename. A default weight of 1 is used if none is specified. Weights
----------------
This isn't a very user-friendly description. I would describe it as: "instead of `<filename>` pass `<filename>:<weight>`, where `<weight>` is a decimal integer >= 1. A weight of 1 is assume if just `<filename>` by itself is passed"


http://reviews.llvm.org/D14547