[PATCH] D14690: Don't force std::set for SmallSet

[Rafael Espíndola via llvm-commits]

On 2 December 2015 at 14:42, Chandler Carruth <chandlerc at gmail.com> wrote:
> chandlerc added inline comments.
>
> ================
> Comment at: lib/Analysis/AliasAnalysisEvaluator.cpp:149
> @@ -147,3 +148,3 @@
>    SetVector<Value *> Pointers;
> -  SetVector<CallSite> CallSites;
> +  SetVector<CallSite, std::vector<CallSite>, std::set<CallSite>> CallSites;
>    SetVector<Value *> Loads;
> ----------------
> Why do we want a std::set here?
>
> ================
> Comment at: utils/TableGen/AsmMatcherEmitter.cpp:1724
> @@ -1723,3 +1723,3 @@
>
> -static unsigned getConverterOperandID(const std::string &Name,
> -                                      SetVector<std::string> &Table,
> +typedef SetVector<std::string, std::vector<std::string>, std::set<std::string>>
> +    StringSet;
> ----------------
> Why not let this use DenseSet?

In both cases because we don't have a DenseMapInfo.

Cheers,
Rafael