[llvm] r254511 - Fix buildbots broken by r254508
Andy Gibbs via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 2 06:22:18 PST 2015
Author: andyg
Date: Wed Dec 2 08:22:18 2015
New Revision: 254511
URL: http://llvm.org/viewvc/llvm-project?rev=254511&view=rev
Log:
Fix buildbots broken by r254508
g++ 4.7 does not allow an inline defaulted virtual destructor to be overridden,
giving the error "looser throw specifier for ... overridding ~SCEVPredicate()
noexcept (true)" (see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53613).
The work-around given in the bug report above has been utilised here.
Modified:
llvm/trunk/include/llvm/Analysis/ScalarEvolution.h
Modified: llvm/trunk/include/llvm/Analysis/ScalarEvolution.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Analysis/ScalarEvolution.h?rev=254511&r1=254510&r2=254511&view=diff
==============================================================================
--- llvm/trunk/include/llvm/Analysis/ScalarEvolution.h (original)
+++ llvm/trunk/include/llvm/Analysis/ScalarEvolution.h Wed Dec 2 08:22:18 2015
@@ -183,7 +183,7 @@ namespace llvm {
protected:
SCEVPredicateKind Kind;
- virtual ~SCEVPredicate() = default;
+ virtual ~SCEVPredicate();
SCEVPredicate(const SCEVPredicate&) = default;
SCEVPredicate &operator=(const SCEVPredicate&) = default;
@@ -211,6 +211,9 @@ namespace llvm {
/// if this is a SCEVUnionPredicate.
virtual const SCEV *getExpr() const = 0;
};
+
+ /// Default destructor must be defined outside class due to g++ PR53613.
+ SCEVPredicate::~SCEVPredicate() = default;
inline raw_ostream &operator<<(raw_ostream &OS, const SCEVPredicate &P) {
P.print(OS);
More information about the llvm-commits
mailing list