[PATCH] D15060: [ELF] - Implemented some GD, LD and IE TLS access models for x86 target.
Rui Ueyama via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 1 13:05:13 PST 2015
ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.
LGTM with a few nits.
================
Comment at: ELF/Target.cpp:338
@@ -330,1 +337,3 @@
break;
+ case R_386_TLS_GD:
+ case R_386_TLS_LDM:
----------------
Move this after R_386_PC32.
================
Comment at: ELF/Target.cpp:341
@@ +340,3 @@
+ case R_386_TLS_TPOFF: {
+ uint64_t Offset = SA - Out<ELF32LE>::Got->getVA() -
+ Out<ELF32LE>::Got->getNumEntries() * 4;
----------------
Offset -> V for consistency.
================
Comment at: ELF/Target.cpp:347
@@ +346,3 @@
+ }
+ case R_386_TLS_LDO_32:
+ write32le(Loc, SA);
----------------
Move this before R_386_TLS_PC32 to sort.
http://reviews.llvm.org/D15060
More information about the llvm-commits
mailing list