[PATCH] D15100: [PGO] Add support for reading multiple versions of indexed profile format profile data

[Vedant Kumar via llvm-commits]

vsk added a comment.

Thanks. With one simplification this lgtm --


================
Comment at: lib/ProfileData/InstrProfReader.cpp:542
@@ +541,3 @@
+        Start + HashOffset, Cur, Start, HashType, FormatVersion);
+  else
+    llvm_unreachable("Unsupported profile data version");
----------------
The check on line 522 errors out with a diagnostic for this already. We can safely omit the conditional and say `Index.reset(new InstrProfReaderIndex ...)`.


http://reviews.llvm.org/D15100