[PATCH] D14508: AMDGPU/SI: Correctly emit program global variables when targeting HSA

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 1 09:08:24 PST 2015


arsenm added inline comments.

================
Comment at: lib/Target/AMDGPU/AMDGPUHSATargetObjectFile.cpp:58-62
@@ -33,1 +57,7 @@
 
+  if (AMDGPU::isGlobalSegment(GV) && isAgentAllocation(GV))
+    return DataGlobalAgentSection;
+
+  if (AMDGPU::isGlobalSegment(GV) && isProgramAllocation(GV))
+    return DataGlobalProgramSection;
+
----------------
The isAgentAllocation vs. isProgramAllocation can be moved under a single isGlobalSegment


http://reviews.llvm.org/D14508





More information about the llvm-commits mailing list