[llvm] r254201 - [ARM] Generate ABI_optimization_goals build attribute, as described in the ARM ARM.

Artyom Skrobov via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 1 02:32:12 PST 2015


Thanks for that Renato!

However, I didn't see any buildbot failures after my follow-up fix (r254202)

OK to re-commit the two?


-----Original Message-----
From: Renato Golin [mailto:renato.golin at linaro.org] 
Sent: 28 November 2015 17:29
To: Artyom Skrobov
Cc: LLVM Commits
Subject: Re: [llvm] r254201 - [ARM] Generate ABI_optimization_goals build attribute, as described in the ARM ARM.

On 27 November 2015 at 15:30, Artyom Skrobov via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Author: askrobov
> Date: Fri Nov 27 09:30:51 2015
> New Revision: 254201
>
> URL: http://llvm.org/viewvc/llvm-project?rev=254201&view=rev
> Log:
> [ARM] Generate ABI_optimization_goals build attribute, as described in the ARM ARM.

Hi Artyom,

Too many problems came from this patch and your fix didn't work on
self-hosting, sanitizer and test-suite on ARM.

I've reverted on  r254234, please check those three builds natively on
ARM before re-committing your patch.

Also, please check back on *all* the bots that went red with your
patch after you try to fix them, to make sure they go back to green.

thanks,
--renato





More information about the llvm-commits mailing list