[PATCH] D12781: PGO IR-level instrumentation infrastructure

[David Li via llvm-commits]

davidxl added inline comments.

================
Comment at: test/Transforms/PGOProfile/loop2.ll:9
@@ +8,3 @@
+
+define i32 @test_nested_for(i32 %r, i32 %s, i32 %t) {
+entry:
----------------
silvas wrote:
> What is the importance of testing a nested for loop? What part of the code are you trying to exercise that isn't covered by loop1.ll?
Having loop nest in the test for better coverage is fine -- but looks like we don't actually need 3-deep nest -- a 2-deep loop nest is good enough and will be easier to read.

loop1.ll has a loop with top test. How about a loop test with bottom testing. Also a loop with more control flow inside the body, and a loop with early exit might be nice to have -- but those can be added later as follow ups if needed.


http://reviews.llvm.org/D12781