[PATCH] D15093: Fix the assert in Annotate the loop in SIAnnotateControlFlow pass when the loop terminator condition is a constant.

[Matt Arsenault via llvm-commits]

arsenm added a comment.

The test is missing check lines, so FileCheck will error on it


================
Comment at: test/CodeGen/AMDGPU/si-annotate-cfg-loop-assert.ll:1-2
@@ +1,3 @@
+; REQUIRES: asserts
+; XFAIL: *
+; RUN: llc -march=amdgcn -mcpu=kaveri  < %s | FileCheck %s
----------------
Isn't this fixing the test? Why is this xfailed?

================
Comment at: test/CodeGen/AMDGPU/si-annotate-cfg-loop-assert.ll:6-7
@@ +5,4 @@
+
+target datalayout = "e-i64:64-v16:16-v24:32-v32:32-v48:64-v96:128-v192:256-v256:256-v512:512-v1024:1024"
+target triple = "spir64-unknown-unknown"
+
----------------
These should be removed

================
Comment at: test/CodeGen/AMDGPU/si-annotate-cfg-loop-assert.ll:11
@@ +10,3 @@
+; Function Attrs: norecurse nounwind uwtable
+define spir_kernel void @test(i32, i32, i32 addrspace(1)* nocapture, i32, i32, i32, i32) #0 align 2 {
+  %8 = icmp ne i32 %0, 0
----------------
Remove the align 2

================
Comment at: test/CodeGen/AMDGPU/si-annotate-cfg-loop-assert.ll:15
@@ +14,3 @@
+  %or.cond.i.i = and i1 %8, %9
+  br i1 %or.cond.i.i, label %.lr.ph.i.i.preheader, label %"_ZZ9test_mainvENK3$_0clEN6Kalmar5indexILi2EEE.exit"
+
----------------
Can you run opt -strip -instnamer on this test?


http://reviews.llvm.org/D15093