[PATCH] D14357: [ARM] Enable shrink-wrapping by default

Quentin Colombet via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 30 14:12:19 PST 2015


Nice catch!

Looks like we could produce an error when we see this kind of assembly.

Q.
> On Nov 23, 2015, at 9:54 AM, A. Skrobov <artyom.skrobov at arm.com> wrote:
> 
> tyomitch added a subscriber: tyomitch.
> tyomitch added a comment.
> 
> This change led to generation of invalid code on Thumb1 targets.
> 
> Attaching a reproducer. The function epilogue gets compiled into `pop {r4, r5, r6, lr}`, which is invalid for Thumb1; then, it's replaced with a (valid) `pop {r4, r5, r6}` instruction, which leaves the stack unbalanced.
> 
> F1110733: broken.ll <http://reviews.llvm.org/F1110733>
> 
> 
> Repository:
>  rL LLVM
> 
> http://reviews.llvm.org/D14357
> 
> 
> 



More information about the llvm-commits mailing list