[PATCH] D14623: [ThinLTO] Comdat importing fixes and related cleanup

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 30 13:49:58 PST 2015


> Right, which is why I have stripDeclsFromComdats() in this patch (see
> the header comments for that new routine). Forgot about that, so I
> think the issue with the change made in r254170 interacting badly with
> comdat groups is not an issue. So the main thing is that what we want
> here is for the alias to become a decl in the importing module, which
> happens during global value proto linking at head and as a post-pass
> after lazy linking in this patch.


What I don't get it is why copy it just to drop it in the end. Can't
we make the right decision when first looking at f2?

Cheers,
Rafael


More information about the llvm-commits mailing list