[zorg] r247950 - [zorg] For lldb builders, add step 'update scripts' to download scripts from aosp repo

Ying Chen via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 30 11:41:33 PST 2015


On Thu, Nov 26, 2015 at 7:20 AM, Ed Maste <emaste at freebsd.org> wrote:

>
> >
> > +    # Update scripts
> > +    getShellCommandStep(f, name='update scripts',
> > +                        command=['updateScripts' + scriptExt])
>
> Should this one be [pathSep + 'updateScripts' + ...?


updateScripts should be included in the system path for initial checkout of
the scripts, while the rest of scripts will be updated by updateScript
step, and put into scripts directory.
Since it is not guaranteed scripts directory and this file exists before
calling "update scritps" step. For example, in the initial run or if we
need to clean the build directory after every build and etc.
The thought is put updateScrpts to system path as pre-condition of builder
setup.


>


> Also, is getLLDBScriptCommandsFactory intended to be a general purpose
> LLDB builder or Android-specific?
>

It is intended to be general purpose of LLDB builder or for "any builder".

This factory only defines the prototype of build steps, but not the actual
commands.
You could provide customized implementation to each step.
For example, you could write your own code for build steps and upload them
to some repository, then have updateScripts to get your script from the
repository.

The major purpose of adding this factory is to avoid the rebooting of
buildbot master for build command changes.
If we would like to change any commands, like switching from debug build to
release build, adding extra test flags, we only need to make change to
scripts and the change will be reflected in the next build.

Please let me know if you have further questions.

Thanks,
Ying
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151130/826d85b1/attachment.html>


More information about the llvm-commits mailing list