[PATCH] D14827: Adding support for missing variations of X86 string related instructions
Reid Kleckner via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 30 11:18:12 PST 2015
rnk added a comment.
Craig, can you give us a second opinion here?
These string instructions need a memory operand size, but the encodings only support [esi]/[edi] as a memory operand. If the users asks for `ins byte ptr [eax], dx` and we assemble it to `ins byte ptr es:[edi], dx`, it seems highly likely that the user made a mistake.
I'm trying to insist that we should either error or warn when the instruction that the user asked for is not encodable.
Repository:
rL LLVM
http://reviews.llvm.org/D14827
More information about the llvm-commits
mailing list