[PATCH] D15000: [ELF] - Implemented @tlsgd optimization (GD->IE case, x64).

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 30 10:20:06 PST 2015


grimar added inline comments.

================
Comment at: ELF/OutputSections.cpp:226-231
@@ -225,2 +225,8 @@
     if (Body && Target->isTlsGlobalDynamicReloc(Type)) {
+      if (Target->isTlsOptimized(Type, Body)) {
+        P->setSymbolAndType(Body->getDynamicSymbolTableIndex(),
+                            Target->getTlsGotReloc(), Config->Mips64EL);
+        P->r_offset = Out<ELFT>::Got->getEntryAddr(*Body);
+        continue;
+      }
       P->setSymbolAndType(Body->getDynamicSymbolTableIndex(),
----------------
ruiu wrote:
> There is really a concerning trend that this function gets longer and longer over time. Probably it's time to split up into multiple small functions with comments.
Done.


http://reviews.llvm.org/D15000





More information about the llvm-commits mailing list