[PATCH] D15045: [ELF] Rearrange relocation codes in natural order. NFC.

Igor Kudrin via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 30 10:07:34 PST 2015


ikudrin added a comment.

In http://reviews.llvm.org/D15045#298613, @ruiu wrote:

> Is this alphabetical order?


I meant this one: Natural sort order <https://en.wikipedia.org/wiki/Natural_sort_order>.


================
Comment at: ELF/Target.cpp:746-753
@@ -741,2 +745,10 @@
   case R_PPC64_TOC16_DS:    Type = R_PPC64_ADDR16_DS;    SA -= TB; break;
+  case R_PPC64_TOC16_HA:
+    Type = R_PPC64_ADDR16_HA;
+    SA -= TB;
+    break;
+  case R_PPC64_TOC16_HI:
+    Type = R_PPC64_ADDR16_HI;
+    SA -= TB;
+    break;
   case R_PPC64_TOC16_LO:    Type = R_PPC64_ADDR16_LO;    SA -= TB; break;
----------------
ruiu wrote:
> Keep the original style. (I know this style is a bit controversial, but at least I don't want to change that in this patch.)
Oops, clang-formatted unintentionally.


http://reviews.llvm.org/D15045





More information about the llvm-commits mailing list