[PATCH] D15060: [ELF] - Implemented some GD, LD and IE TLS access models for x86 target.

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/OutputSections.cpp:84
@@ -83,3 +83,3 @@
 template <class ELFT> void GotSection<ELFT>::addDynTlsEntry(SymbolBody *Sym) {
-  Sym->GotIndex = Target->getGotHeaderEntriesNum() + Entries.size();
+  Sym->GlobDynIndex = Target->getGotHeaderEntriesNum() + Entries.size();
   // Global Dynamic TLS entries take two GOT slots.
----------------
Why do we need a different member variable than GotIndex?

================
Comment at: ELF/OutputSections.h:126
@@ -125,1 +125,3 @@
+  uintX_t getGlobalDynAddr(const SymbolBody &B) const;
+  uintX_t getEntriesNum() const { return Entries.size(); }
 
----------------
getNumEntries

================
Comment at: ELF/Target.cpp:350
@@ +349,3 @@
+    write32le(Loc, Offset);
+  } break;
+  case R_386_TLS_LDO_32:
----------------
    break;
  }


http://reviews.llvm.org/D15060