[PATCH] D15080: [asan] Reports suppressions for ASan recovery mode (compiler-rt part).

[Yury Gribov via llvm-commits]

ygribov added inline comments.

================
Comment at: lib/asan/asan_flags.inc:143
@@ +142,2 @@
+          "Suppress multiple reports for single source location in "
+          "halt_on_error = false mode.")
----------------
Do we need this flag? AFAIK UBSan suppresses dups unconditionally.

================
Comment at: lib/asan/asan_rtl.cc:135
@@ -128,1 +134,3 @@
+  ReportGenericError(pc, bp, sp, addr, is_write, size, 0, false);          \
+}                                                                          \
 
----------------
Whitespace padding too large.

================
Comment at: test/asan/TestCases/Posix/halt_on_error-torture-2.cc:1
@@ +1,2 @@
+// Suppressions test recovery mode with many threads.
+//
----------------
I wonder if this heavy multithreaded test is worth it.


Repository:
  rL LLVM

http://reviews.llvm.org/D15080