[PATCH] D15079: [asan] Reports suppressions for ASan recovery mode (LLVM core part).

[Yury Gribov via llvm-commits]

ygribov added inline comments.

================
Comment at: lib/Transforms/Instrumentation/AddressSanitizer.cpp:1017
@@ -1009,3 +1016,3 @@
       Call = IRB.CreateCall(AsanErrorCallbackSized[IsWrite][1],
                             {Addr, SizeArgument, ExpVal});
   } else {
----------------
Is it possible move call out of if-else and set argument ArrayRefs there instead? Same for other places below.

================
Comment at: lib/Transforms/Instrumentation/AddressSanitizer.cpp:1469
@@ -1439,1 +1468,3 @@
+      else if (Recover)
+        OptType = IntptrTy;
       AsanErrorCallbackSized[AccessIsWrite][Exp] =
----------------
Perhaps used nested conditional operator?


Repository:
  rL LLVM

http://reviews.llvm.org/D15079